search

intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
118 stars 152 forks source link

Typescript definitions #93

Open ibox4real opened 3 years ago

ibox4real commented 3 years ago

Any chance we would get Typescript support for the oauth-jsclient?

abisalehalliprasan commented 3 years ago

@ibox4real : We do not have any immediate plans at the moment to provide Typescript support, however, I can take this information to my team and see if we can prioritize and have this on the roadmap.

Meanwhile, there is a typescript branch If you'd be interested to take a look at.

prateekkathal commented 3 years ago

@ibox4real You can use the index.d.ts file in the root folder of above mentioned branch in your src/@types/intuit-oauth folder by declaring a module with the name 'intuit-oauth'.

Something like this 

declare module 'intuit-oauth' {
  // ... index.d.ts code
  // replace all 'declare' keywords with 'export'
}

Just to be clear, this is a temporary solution till the time types are added to the master/release branch..

MitchWeber commented 3 years ago

Any updates when the types will be released?

gmicek commented 3 years ago

hey @abisalehalliprasan , would you all please go ahead and merge the typescript branch and support into master and publish? You can even mark it experimental or something. At this time, I think a lot of the users including myself are either just copying the types into our own type directories or writing our own types.

I think it will be more helpful to merge to master now and note if they may not be complete than to keep them hidden on a separate branch that most users aren't aware of. Thanks!

abisalehalliprasan commented 3 years ago

@gmicek : There a few things which need to be tested before we release the typescript version.

We will prioritize a release very soon. Thanks for the understanding everyone. Will keep this thread posted with updates.

digibake commented 2 years ago

I noticed there's a new pull request which adds typescript definitions, does this mean there'll be a new release soon? It would be really a useful addition.

anilkumarbp commented 2 years ago

@digibake : Sorry for the delay. Let me be clear that, we are not working towards the migration of the entire library to TS. I'm not a 100% familiar with this so any feedback would be great.

Do you think publishing the typings alone would help us resolve here?

GuiSim commented 2 years ago

Can we get an update here? It's been years since this was "nearly merged" https://github.com/intuit/oauth-jsclient/issues/33