intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
124 stars 159 forks source link

[typescript][enhancement]: Update typescript sample with the latest typescript definitions #99

Open abisalehalliprasan opened 3 years ago

abisalehalliprasan commented 3 years ago

Hacktoberfest is underway right now and we would love for you to contribute πŸš€ . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

Problem

Update typescript sample with the latest typescript definitions index.d.ts file

Fix Needed

Update typescript sample with the latest typescript definitions and test the sample is working.

Instructions to use the sample app

In order to test the typings locally from the sample project, you'll need to link the intuit-oauth package with yarn or npm.

# Link local intuit-oauth branch with typings support to sample typescript project
yarn link
cd sample/typescript
yarn link intuit-oauth

PR Guidelines

Kindly follow the below instructions to submit your PR :

Once ready, please submit a PR to the typescript branch here.
Note : PR's will be merged to the master branch once all the testing is completed.

100mik commented 3 years ago

Hey! I'd like to take a shot at this if it's fine.

abisalehalliprasan commented 3 years ago

@100mik : Awesome. That would be great. However, this issue/fix would be dependent on #100 ( as the sample should refer to the latest typings ).

I suggest you can start on this story once we start getting more updates on the #100. Does that sound good to you?

100mik commented 3 years ago

Yes that's perfectly fine. I don't mind helping out if needed once the current assignee has taken a shot at #100 Cheers!