intuit / postcss-themed

A PostCSS plugin for generating themes.

MIT License

62 stars 31 forks source link

optimizeSingleTheme: Detect missing keys and provide warning. #16

Closed tylerkrupicka closed 4 years ago

tylerkrupicka commented 4 years ago

What Changed

We have a while loop that checks for all @themes being removed from a declaration, however when in optimize mode if there was no key I was not replacing the theme. This led to an infinite loop.

My change adds a warning and removes the invalid declaration if this is encountered.

Why

Todo:

[ ] Add tests
[ ] Add docs
[ ] Add yourself to contributors (run yarn contributors:add)

hipstersmoothie commented 4 years ago

:rocket: PR was released in v2.0.1 :rocket: