pass port to localgrid.start

intuit / proof

A tapable integration testing library for your Storybook stories

https://intuit.github.io/proof/

MIT License

86 stars 30 forks source link

pass port to localgrid.start #45

Closed hainessss closed 4 years ago

hainessss commented 4 years ago

Okay this looks to be working. I am a selenium n00b, so guidance appreciated.

I am passing the port to the localgrid on the call to start but I think it should be passed to the constructor? I just couldn't see how to do that given that the port is not accounted for in the default export getInstance.

Thanks,

hainessss commented 4 years ago

This approach was ok? @adierkens

adierkens commented 4 years ago

:rocket: PR was released in v0.0.18 :rocket: