search

intuit / simple_deploy

Maintenance Mode - Simple Deploy is an opinionated CLI tool for managing AWS Cloud Formation Stacks.
MIT License
64 stars 22 forks source link

Gracefully error out when omitting a required parameter during create #136

Closed thbishop closed 11 years ago

thbishop commented 11 years ago

It shouldn't dump a stack trace

2012-12-12 12:01:05 -0800 INFO : Read AvailabilityZone=us-west-1a
2012-12-12 12:01:11 -0800 INFO : Creating Cloud Formation stack ssp-pod-1-preprod-vpc-1-subnet-1.
2012-12-12 12:01:14 -0800 ERROR : Template requires parameter: RouteTableId
/Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/stackster-0.4.0/lib/stackster/aws/cloud_formation/error.rb:25:in `block in process': Template requires parameter: RouteTableId (Stackster::Exceptions::CloudFormationError)
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/stackster-0.4.0/lib/stackster/aws/cloud_formation/error.rb:16:in `each'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/stackster-0.4.0/lib/stackster/aws/cloud_formation/error.rb:16:in `process'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/stackster-0.4.0/lib/stackster/aws/cloud_formation.rb:22:in `rescue in create'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/stackster-0.4.0/lib/stackster/aws/cloud_formation.rb:16:in `create'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/stackster-0.4.0/lib/stackster/stack/stack_creater.rb:16:in `create'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/stackster-0.4.0/lib/stackster/stack.rb:25:in `create'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/simple_deploy-0.6.3/lib/simple_deploy/stack.rb:20:in `create'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/simple_deploy-0.6.3/lib/simple_deploy/cli/create.rb:41:in `create'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/simple_deploy-0.6.3/lib/simple_deploy/cli.rb:34:in `start'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/gems/simple_deploy-0.6.3/bin/simple_deploy:6:in `<top (required)>'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/bin/simple_deploy:23:in `load'
    from /Users/tbishop/.rvm/gems/ruby-1.9.3-p125/bin/simple_deploy:23:in `<main>'
weavenet commented 11 years ago

These are likely due to Stackster no longer exiting deep within the Cloud Formation mgmt class.

weavenet commented 11 years ago

released in 0.6.5