I brought everything over from stackster that I feel we need for simple_deploy to run independently. I got all of the specs to go green.
The hardest part of the the merge was the configuration object. simple_deploy passed one version of it all over its code. stackster passed another version of it all over its code. I tried to find a happy medium between them that would limit the amount of code I had to refactor during the merge. That enabled me to get all of the specs to go green.
I then started testing each command in a clean gemset. Things went well with the environments, list, outputs, attributes and parameters commands. When I tried a create my configuration nightmares came back.
The StackAttributeFormater class broke if I passed it a pseudo stackster config. The Entry class broke if I passed it a simple_deploy config. This is like being between a rock and a hard place. The only solution to that I see without refactoring is to race through the code and normalize configuration usage. Unfortunately, I see that as throw away code.
That caused me to ask about jumping directly to configuration refactoring. That is probably the most critical refactoring I have seen.
I will fix any issues you find here and take any suggestions you have for an interim configuration if you see them. Once we have this merged, I will immediately branch again and start work on configuration refactoring.
I brought everything over from stackster that I feel we need for simple_deploy to run independently. I got all of the specs to go green.
The hardest part of the the merge was the configuration object. simple_deploy passed one version of it all over its code. stackster passed another version of it all over its code. I tried to find a happy medium between them that would limit the amount of code I had to refactor during the merge. That enabled me to get all of the specs to go green.
I then started testing each command in a clean gemset. Things went well with the environments, list, outputs, attributes and parameters commands. When I tried a create my configuration nightmares came back.
The StackAttributeFormater class broke if I passed it a pseudo stackster config. The Entry class broke if I passed it a simple_deploy config. This is like being between a rock and a hard place. The only solution to that I see without refactoring is to race through the code and normalize configuration usage. Unfortunately, I see that as throw away code.
That caused me to ask about jumping directly to configuration refactoring. That is probably the most critical refactoring I have seen.
I will fix any issues you find here and take any suggestions you have for an interim configuration if you see them. Once we have this merged, I will immediately branch again and start work on configuration refactoring.
Thanks.