Closed bradly closed 11 years ago
Bradly,
Simple deploy is under a major refactoring so please only use released versions. Master is not releasable until we tag it with a new version.
Thanks
Sent from my iPhone
On May 9, 2013, at 7:30 PM, "Bradly Feeley" notifications@github.com wrote:
rb
@bradly only uses gems pulled directly from master....
That problem is fixed on my Thor branch. Unfortunately, that branch is on hold.
Also, if we have software the is publicly released, I think anyone who insists on using master is under YMMV.
Sent from my iPhone
On May 9, 2013, at 7:46 PM, "Brett Weaver" notifications@github.com<mailto:notifications@github.com> wrote:
@bradlyhttps://github.com/bradly only uses gems pulled directly from master....
— Reply to this email directly or view it on GitHubhttps://github.com/intuit/simple_deploy/issues/182#issuecomment-17701653.
Yeah, I was actually working on simple_deploy, so I just branched off master and then found the issue when testing my branch. I'll reset my branch to the latest tag and test off that.
@bradly @brettweavnet I looked back at my Thor branch and I have two fixes that will stabilize master while we are on hold with the cli changes. I will port those over today after I deploy the new RBAS development environment.
This is my bad. I have been making so many wholesale changes to simple_deploy that periodic merges to master were the only way to keep our sanity. With that, I lost the urgency of keeping master stable. I should have ported these fixes as soon as I found them when testing Thor. Sorry.
Not your bad, we all made a decision to break master for this refactor. We still have a stable release, so don't kill yourself trying to get these changes in asap.
@bradly Your issue should be fixed with this merge. If so, let me know and I will close this. Thanks.
Trying to deploy with current master 9b54bb42dc4e31eb9cc9e25480c63a975e8a6ce7
$ simple_deploy deploy -e lcpreprod -n lc-pod-2-qa-1-worker-3 2013-05-09 19:16:42 -0700 ERROR : 1 validation error detected: Value '["lc-pod-2-qa-1-worker-3"]' at 'stackName' failed to satisfy constraint: Member must satisfy regular expression pattern: ([a-zA-Z][-a-zA-Z0-9])|(arn:aws:[-a-zA-Z0-9:/.+]) /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/bundler/gems/simple_deploy/lib/simple_deploy/aws/cloudformation/error.rb:24:in `block in process': 1 validation error detected: Value '["lc-pod-2-qa-1-worker-3"]' at 'stackName' failed to satisfy constraint: Member must satisfy regular expression pattern: ([a-zA-Z][-a-zA-Z0-9])|(arn:aws:[-a-zA-Z0-9:/.+]) (SimpleDeploy::Exceptions::CloudFormationError)