search

intuit / simple_deploy

Maintenance Mode - Simple Deploy is an opinionated CLI tool for managing AWS Cloud Formation Stacks.
MIT License
64 stars 22 forks source link

Update fog excon #215

Closed ccloes-intuit closed 11 years ago

ccloes-intuit commented 11 years ago

Update to the new version of fog and excon to resolve error 500 errors

thbishop commented 11 years ago

@ccloes-intuit why is this explicitly depending on unf and unf_ext?

ccloes-intuit commented 10 years ago

@thbishop ... I bound these because they are called out as dependencies for fog/excon and I don't want them to drift from known working gems. I did this because of the problems we are seeing with excon since it was not pinned to a specific version. These gems are new requirements for the latest versions so I pinned them.

thbishop commented 10 years ago

@ccloes-intuit hmmm. from everything i see, they are development dependencies of fog (not runtime). am i missing something? if it does not in fact rely on these for runtime, then they should be removed from the gemspec.

here are the rubygems pages for fog and excon.

and here's a fog install in a clean env (note that unf and unf_ext are not installed):

tbishop in ~/Downloads/tmp/sd_gem_test (12:26:16 || 1.9.3-p429 || master*)
# gem list

*** LOCAL GEMS ***

rbenv-gem-rehash (1.0.0)

tbishop in ~/Downloads/tmp/sd_gem_test (12:26:18 || 1.9.3-p429 || master*)
# gem install fog -v '= 1.18.0'
Fetching: builder-3.2.2.gem (100%)
Fetching: excon-0.28.0.gem (100%)
Fetching: formatador-0.2.4.gem (100%)
Fetching: multi_json-1.8.2.gem (100%)
Fetching: mime-types-2.0.gem (100%)
Fetching: net-ssh-2.7.0.gem (100%)
Fetching: net-scp-1.1.2.gem (100%)
Fetching: mini_portile-0.5.2.gem (100%)
Fetching: nokogiri-1.6.0.gem (100%)
Building native extensions.  This could take a while...
Fetching: ruby-hmac-0.4.0.gem (100%)
Fetching: fog-1.18.0.gem (100%)
Successfully installed builder-3.2.2
Successfully installed excon-0.28.0
Successfully installed formatador-0.2.4
Successfully installed multi_json-1.8.2
Successfully installed mime-types-2.0
Successfully installed net-ssh-2.7.0
Successfully installed net-scp-1.1.2
Successfully installed mini_portile-0.5.2
Successfully installed nokogiri-1.6.0
Successfully installed ruby-hmac-0.4.0
Successfully installed fog-1.18.0
11 gems installed

tbishop in ~/Downloads/tmp/sd_gem_test (12:28:39 || 1.9.3-p429 || master*)
# gem list

*** LOCAL GEMS ***

builder (3.2.2)
excon (0.28.0)
fog (1.18.0)
formatador (0.2.4)
mime-types (2.0)
mini_portile (0.5.2)
multi_json (1.8.2)
net-scp (1.1.2)
net-ssh (2.7.0)
nokogiri (1.6.0)
rbenv-gem-rehash (1.0.0)
ruby-hmac (0.4.0)

tbishop in ~/Downloads/tmp/sd_gem_test (12:28:47 || 1.9.3-p429 || master*)
#
ccloes-intuit commented 10 years ago

@thbishop I think you are right... I saw them as dev dependencies added them hastily to avoid future problems. Thanks for catching!

Are you good with releasing this minus those runtime dependencies? Should we roll another beta prior to release?

thbishop commented 10 years ago

@ccloes-intuit i think so (remember to update the CHANGELOG as well)