search

intuit / simple_deploy

Maintenance Mode - Simple Deploy is an opinionated CLI tool for managing AWS Cloud Formation Stacks.
MIT License
64 stars 22 forks source link

Added a clone command #88

Closed ghost closed 12 years ago

ghost commented 12 years ago

This one really needs a code review.

I want to make sure I am filtering everything you want filtered. I also want to make sure once it has attributes for the new stack it should essentially follow what the create command does.

I ran this against dev and tried cloning the ssp-agent. It rolled back with the same wait error we got the other day when we did the app before the worker. I wasn't surprised as I essentially jumped in the middle by grabbing the ssp-agent.

It was still there after rollback so I listed the attributes the clone command had created. The only ones I wondered about were the URL ones for App, ChefRepo and Cookbooks.

I suspect we will go back and forth a few times on this branch before we have it ready to merge. At least it is now in progress.

ghost commented 12 years ago

Brett - I went with your suggestions. However, now you guys have put a bug in my head about using tap with inject/reduce. If I come up with a version of that I like I might flip to that in the future. Thanks. This is like having a song in my head all day.