search

intuit / ssp

Variant of sdp project based on the sp size unit.
MIT License
541 stars 107 forks source link

ssp lib not support latest high resolution devices #6

Closed ibnekhan closed 3 years ago

ibnekhan commented 6 years ago

I have been using this library for years but now as new device with slim dimensions and high resolutions are coming like samsung galaxy s8 and s9 not supporting this lib.

elhanan-mishraky commented 6 years ago

@ibnekhan could you please add some screenshots to clarify?

ibnekhan commented 6 years ago

@elhanan-mishraky have you checked this on latest high resolution devices like galaxy s8 or s9? On these devices TEXT become small not maintained same size.

yerramnaveen commented 5 years ago

@ibnekhan can you share screen-shots. How much is the difference?

radeshf commented 5 years ago

I think this is because this error warning

The dimen "_100ssp" in values-sw300dp has no declaration in the base values folder; this can lead to crashes when the resource is queried in a configuration that does not match this qualifier

So i think it will be fix by copy positive_ssps of values-sw300dp in to values folder

elhanan-mishraky commented 5 years ago

I checked it again and _100ssp appears in the base values folder. I think that the issue is because ssp values are scaling based on the screen width. For devices with extreme width:hight proportion it doesn't work perfectly. I will appreciate any assitance with solving this issue as I couldn't find a solution.

ghost commented 5 years ago

I have been using this library for years but now as new device with slim dimensions and high resolutions are coming like samsung galaxy s8 and s9 not supporting this lib. @ibnekhan I ahve same proble in 2,960×1,440 resolution, have you got any solution

arungoyal commented 4 years ago

i am facing the same issue, my app is live and a lot of users are facing this issue and very bad for my product. Please check on samsung SM-G950F and resolve this issue.