intuit / superglue

Superglue is a lineage-tracking tool built to help visualize the propagation of data through complex pipelines composed of tables, jobs and reports.
Apache License 2.0
158 stars 37 forks source link

Add logging in the application #24

Open sambekar15 opened 4 years ago

sambekar15 commented 4 years ago

Is your feature request related to a problem? Please describe. Currently the application does not have logging. The errors are printed on console. Using logging in your application can be useful for monitoring, debugging, error tracking, and business intelligence.

For eg - Hitting the API - http://localhost:8080/api/v1/lineage/table/LOREM?bw=-1&fw=-1 returns empty response but stacktrace is not logged. This makes it default to debug.

Describe the solution you'd like Integrate with Play API logging - https://www.playframework.com/documentation/2.8.x/ScalaLogging Log the error from API call Desired output structure in log would be : %d{yy/MM/dd HH:mm:ss}; thread=%thread; level=%p; %marker; class=%c; method=%method; lineNumber=%L; msg=%message%n%xException

otobrglez commented 4 years ago

Hello @sambekar15!

Can you provide a splash more information about desired logging output structure or anything more then what is already written in this ticket?

Cheers!

sambekar15 commented 4 years ago

Hello @sambekar15!

Can you provide a splash more information about desired logging output structure or anything more then what is already written in this ticket?

Cheers!

* Oto

Sure. Desired output structure in log would be -

%d{yy/MM/dd HH:mm:ss}; thread=%thread; level=%p; %marker; class=%c; method=%method; lineNumber=%L; msg=%message%n%xException