intuit / superglue

Superglue is a lineage-tracking tool built to help visualize the propagation of data through complex pipelines composed of tables, jobs and reports.
Apache License 2.0
155 stars 37 forks source link

issues#19 Lineage API response is inconsistent when only of the queryParam is passed #32

Open codeatri opened 3 years ago

codeatri commented 3 years ago

Fixes #19

cc. @soojison @sambekar15

soojison commented 3 years ago

Hey CC'ing @sambekar15 also to verify. I think the issue ticket is worded imprecisely which probably is adding to the confusion. If I understand the issue ticket correctly, we want to:

So for instance, http://localhost:9000/v1/lineage/table/LOREM?bw=0 => return full FW lineage http://localhost:9000/v1/lineage/table/LOREM?fw=0 => return full BW lineage http://localhost:9000/v1/lineage/table/LOREM?fw=0&bw=0 => return empty lineage http://localhost:9000/v1/lineage/table/LOREM?fw=1 => return fw @ depth 1, full BW lineage and so forth, right?

If that's the case, this fix won't achieve what we want to do

sambekar15 commented 3 years ago

Hey CC'ing @sambekar15 also to verify. I think the issue ticket is worded imprecisely which probably is adding to the confusion. If I understand the issue ticket correctly, we want to:

* return full lineage if no query param is present

* return full fw lineage if no query param for FW lineage is present

* return full bw lineage if no query param for BW lineage present

So for instance, http://localhost:9000/v1/lineage/table/LOREM?bw=0 => return full FW lineage http://localhost:9000/v1/lineage/table/LOREM?fw=0 => return full BW lineage http://localhost:9000/v1/lineage/table/LOREM?fw=0&bw=0 => return empty lineage http://localhost:9000/v1/lineage/table/LOREM?fw=1 => return fw @ depth 1, full BW lineage and so forth, right?

If that's the case, this fix won't achieve what we want to do yeah these conditions are correct