search

intuit / superglue

Superglue is a lineage-tracking tool built to help visualize the propagation of data through complex pipelines composed of tables, jobs and reports.
Apache License 2.0
155 stars 37 forks source link

Superglue Calcite Parser : Upgrade to latest Calcite Version - 1.27.0 #50

Open sambekar15 opened 3 years ago

sambekar15 commented 3 years ago

Is your feature request related to a problem? Please describe. Superglue Calcite Parser : Upgrade to latest Calcite Version - 1.27.0 to take advantage of some of the fixes wrt RLIKE, DATE functions https://calcite.apache.org/downloads/

Describe the solution you'd like Regression and test cases should pass after upgrading to latest calcite version Sql Statement like - 1) select cola from tableA where MAX(realm_email) RLIKE '.+@.+\..+' 2) select cola from tableA where MAX(realm_email) not rlike '.+@.+\..+' should succeed on parsing

vijaya-lakshmi-venkatraman commented 3 years ago

Hi I would like to work on this issue. Please give me some inputs on the changes required.

sambekar15 commented 3 years ago

Hi I would like to work on this issue. Please give me some inputs on the changes required. Sure assigned to you. The change requires upgrading calcite version in build.gradle to 1.27.0 and adding a test case to make sure it works. 1.27.0 has fixes to RLIKE operator. so for example this test case -> "select cola from tableA where MAX(realm_email) RLIKE '.+@.+..+'" in CalciteParserTest should pass.

kulkarnianiket commented 3 years ago

@sambekar15 , can I work on this issue?

kulkarnianiket commented 2 years ago

@sambekar15 created a PR for this. https://github.com/intuit/superglue/pull/58 Can you please take a look?