Support Java 12 Runner Image

intuit / unmazedboot

🐳 Generic SpringBoot Docker files and image management 🍃

MIT License

12 stars 12 forks source link

Support Java 12 Runner Image #2

Closed marcellodesales closed 5 years ago

marcellodesales commented 5 years ago

Description

We currently support Java 11 and below. Create Docker images for Java 12

Steps to Reproduce

Create a new Docker Images for the Builder

Generate the the releases

deepaksn716867 commented 5 years ago

@marcellodesales , I would like to work on it. can you pls give me more context ?

marcellodesales commented 5 years ago

@deepaksn716867 The builder and linker images are already available! https://github.com/intuit/unmazedboot/blob/master/docker-compose.yml#L98

You can extend it and create one for JDK 12 runtime image

dheeraj-tripathi commented 5 years ago

@marcellodesales I would like to give it a try, I can fork and create a PR

marcellodesales commented 5 years ago

@dheeraj-tripathi Sure, whoever sends a PR first I will merge...

dheeraj-tripathi commented 5 years ago

Thanks @marcellodesales , I am building the images "docker-compose build --pull", and images in the repo "sgrio" eg sgrio/java-oracle:jdk_11_centos, are not publicly available, is it okay to replace them with openly available images? or is this expected?

marcellodesales commented 5 years ago

@dheeraj-tripathi absolutely... this was written long time ago... Take a look for an open-source alternative for CENTOS...

dheeraj-tripathi commented 5 years ago

@marcellodesales Created a PR here https://github.com/intuit/unmazedboot/pull/4/files

marcellodesales commented 5 years ago

Fixed by #7