search

intvsteve / VINTage

Various Intellivision-related projects, including the LTO Flash! User Interface application.
GNU General Public License v2.0
3 stars 1 forks source link

Vendor metadata needs protection for control characters #280

Closed intvsteve closed 5 years ago

intvsteve commented 5 years ago

Although issue #257 mentions that Vendor (publisher) metadata will be fixed as part of a deeper change, it is presently directly exposed on the ProgramDescription class.

Ergo: Apply same fix for Vendor on ProgramDesription as for Name and ShortName.

intvsteve commented 5 years ago

This reminds me … It may be worth the effort to explore retiring ProgramDescription as a public class and instead only work via the interface IProgramDescription. This could act as a stepping stone to moving to IProgramRomInformation. The notion is that the current strategy of using XML Attributes is merely a patch.

Now that issues like this have been identified, moving away from the expediency of the automagical XML serialization services to something more targeted specifically for serialization may make more sense.

intvsteve commented 5 years ago

Fixed in commit cb0a5aabfb75f42781729379a95cf0ec99389d84