ROMs in archives act like they're missing

intvsteve / VINTage

Various Intellivision-related projects, including the LTO Flash! User Interface application.

GNU General Public License v2.0

3 stars 1 forks source link

ROMs in archives act like they're missing #333

Open intvsteve opened 4 years ago

intvsteve commented 4 years ago

When you add a ROM to the ROM list while archive support is enabled, the next time you start LUI they act like they're missing, and the 'backup' copy of the ROM is used.

intvsteve commented 4 years ago

Very low sev. This behavior is expected at this time.

When ROMs in archives are identified:

since archive access can be disabled, they are treated as "ephemeral" locations
ephemeral locations automatically make a copy in the 'ROMs' directory and stash an 'alternate' path
ROM list validation is currently unaware of ICompressedArchiveAccess

intvsteve commented 4 years ago

Have not done any investigation of performance of creating ICompressedArchiveAccess instances. E.g. if you have 500 ROMs would validating result in creating / disposing 500 archive accessor instances? And in some cases, e.g. nested archives, doing so may result in extracting temporary copies!

intvsteve commented 4 years ago

Another item to consider here is just how rigorous the validation is. Full validation implies actually computing CRCs of ROMs / .cfg files in archives. This likely means extracting to temporary file because there are scenarios in which seek access to the data stream may occur. Not all archive formats support seek access - hence the side effect of temporary extraction.

These considerations, in addition to memos holding onto StorageLocation means it's possible we'd be keeping many archive instances around. I.e. no 'memo' system for archives themselves is yet implemented.