search

inukshuk / bibtex-ruby

A BibTeX library, parser, and converter for Ruby.
http://inukshuk.github.com/bibtex-ruby
GNU General Public License v3.0
155 stars 35 forks source link

Adding Rubocop #135

Closed mapreal19 closed 5 years ago

mapreal19 commented 5 years ago

Thoughts? I could help with this

inukshuk commented 5 years ago

Certainly, but this might be a lot of work : )

I wrote bibtex-ruby over ten years ago to learn Ruby and though it has evolved to being used in a few serious projects, it's still plainly obvious that it goes back to Ruby 1.8 days... so, adding Rubocop I think would probably call for dusting off the whole project a little bit and tidying up in lots of places. I guess what I'm trying to say is that I'm very much in low-key maintenance mode with this project -- if you're interested in helping out I'm more than happy to assist, but I'm not very involved with the project at the moment.

mapreal19 commented 5 years ago

It's a lot of work if we want all the cops enabled at the first time ;)

I'm actively using this project in my own reference manager so I'll be glad to give a hand here

inukshuk commented 5 years ago

Alright, that's cool! I'll give you write access to the repo, but it's probably best to still work with PRs for anything except minor changes.

Would you like me to push major to rubygems now, or are you doing further police work?

mapreal19 commented 5 years ago

@inukshuk haha 👮 I have some minor changes in progress but that can wait. I think now is best to push the major version and then work from there