search

inukshuk / bibtex-ruby

A BibTeX library, parser, and converter for Ruby.
http://inukshuk.github.com/bibtex-ruby
GNU General Public License v3.0
156 stars 31 forks source link

Fixes @comment and @preamble parsing #57

Closed JLimperg closed 12 years ago

JLimperg commented 12 years ago

The two commits included in this pull request fix a relatively subtle problem where entries starting with @comment and @preamble are considered to be comments or preambles respectively. For instance, it currently isn't possible to load an @commentary{ ... } entry because everything after @comment is supposed to be a comment.

I wasn't quite able to figure out what the BibTeX specification demands in such a case, but unless you've got sources that confirm the current behaviour's validity, I'd consider it bug.

inukshuk commented 12 years ago

Is this good to go?

JLimperg commented 12 years ago

I think so, yes. Can't say I quite understand all the inner workings of your library so I can't guarantee that it doesn't break anything, but I guess as long as the tests pass the havok won't be too major. ;)

inukshuk commented 12 years ago

Landed in 2.1.1. Cheers!

JLimperg commented 12 years ago

Loving it! Now I can replace all those @comentarys with proper @commentarys for my next papers. ;)