Fixes to sorting behavior in Bibliography.

inukshuk / bibtex-ruby

A BibTeX library, parser, and converter for Ruby.

http://inukshuk.github.com/bibtex-ruby

GNU General Public License v3.0

156 stars 31 forks source link

Fixes to sorting behavior in Bibliography. #78

Closed casutton closed 10 years ago

casutton commented 10 years ago

Rename sort to sort! and make destructive
Add sort_by!
(non-destructive sort and sort_by still available as they are provided by Enumerable)

casutton commented 10 years ago

I did not add a sort method because this is provided by Enumerable. Let me know if there's a reason to define this explicitly and if so, I will add it.

I'm not a very experienced Rubyist so let me know if you have any suggestions for things that should be added or changed.

Also feel free to merge with Issue #50 if appropriate.

inukshuk commented 10 years ago

Thanks!

We will probably add a sort method that returns a new Bibliography at some point in the future. Enumerable's sort gives you an array and not a Bibliography object, thus lacking all BibTeX specific features.