search

inukshuk / bibtex-ruby

A BibTeX library, parser, and converter for Ruby.
http://inukshuk.github.com/bibtex-ruby
GNU General Public License v3.0
156 stars 31 forks source link

old-fashioned respond_to? warning #89

Closed vrastogi closed 10 years ago

vrastogi commented 10 years ago

Using Ruby 2.1.2.

While doing a a dump, I get a warning at the caller:

warning: BibTeX::Value#respond_to?(:_dump) is old fashion which takes only one parameter

I do not know ruby much but editing lib/bibtex/value.rb:277 to include a second parameter as def respond_to?(method, include_all=false) fixes the warning. Apparently, this class does not have any private/protected methods and so include_all need not be used in the method's body.

inukshuk commented 10 years ago

Thanks for the heads-up – there are probably a few more of these in the code base.