allow selecting entries /not/ matching an attribute

inukshuk / bibtex-ruby

A BibTeX library, parser, and converter for Ruby.

http://inukshuk.github.com/bibtex-ruby

GNU General Public License v3.0

156 stars 31 forks source link

allow selecting entries /not/ matching an attribute #96

Closed temporaer closed 10 years ago

temporaer commented 10 years ago

there are various kinds of "@incollections" papers, e.g. workshop papers, which I don't want to put in the same list as other papers on my website. This commit allows to use an attribute like a tag list, where you can select or exclude entries.

On the choice of operator (%=): I'm not too fond of it, I'd prefer to use perl notation (=~ and !~), but that would break compatibility. Feel free to suggest an alternative.

inukshuk commented 10 years ago

Looks good to me.

Why would perl notation break compatibility, though? I think we could pick !~ just as well or am I missing something? (I'd rather not use =~ so as not to clash with Ruby syntax too much).

temporaer commented 10 years ago

No, it would work, but I thought it would be more consistent to have the two matching. I'll update the patch for !~ then.

coveralls commented 10 years ago

Coverage decreased (-0.14%) when pulling 4d9342361ee30f3eebfcef1208f2b98f61902437 on temporaer:master into 9fcb61c7b420de30209c4f21ed26c9b83aada3ec on inukshuk:master.

inukshuk commented 10 years ago

Sigh, no idea why this fails on travis (works for me with jruby as well)...

inukshuk commented 10 years ago

I'll try to figure it out and push version 4.0.4 to rubygems asap.

inukshuk commented 10 years ago

It was something completely unrelated after all. Anyway, pushed version 4.0.4 with your changes. Cheers!