search

inukshuk / citeproc-ruby

A Citation Style Language (CSL) Cite Processor
101 stars 22 forks source link

Additional stopwords #23

Closed smoyte closed 10 years ago

smoyte commented 10 years ago

https://github.com/citation-style-language/documentation/blob/master/specification.txt says that words like 'a', 'and', 'the', 'nor', etc. should be stopwords for title case capitalization. Some of those given in the spec were missing from citeproc-ruby.

This was causing invalid capitalization for styles (like MLA) that use title case, e.g. Declaration on Democracy, Political, Economic And Corporate Governance. Clearly 'and' should not be capitalized here.

I have added them. I also changed to the terser %w array init syntax.

Thanks for considering!

smoyte commented 10 years ago

Thanks for your comment on the other PR. Please let me know when this gets accepted and released so I can update my gemfile back to the original gem.

inukshuk commented 10 years ago

Thanks! (Don't worry about the error on Travis – that's something unrelated; and is something that will be changed in the CSL spec so I will amend the test).

inukshuk commented 10 years ago

Just pushed 1.0.4 to Rubygems.

smoyte commented 10 years ago

Wow, fast! Thanks!