search

inukshuk / citeproc-ruby

A Citation Style Language (CSL) Cite Processor
101 stars 22 forks source link

[WIP] Fix style immanent locales #32

Closed walski closed 8 years ago

walski commented 8 years ago

Sorry, please see below

walski commented 8 years ago

So sorry! This wasn't supposed to land here but rather in our fork's repository first :(

I'll close this. We will reopen a PR once all the testing has been done :)

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.08%) to 94.455% when pulling fdfb729e093fbe94d9e94bd359cb0800bbfc198f on easybiblabs:t/fixStyleImmanentLocales into 8708c7bc0810c1f9d5a74f9d10599e3b8ed06138 on inukshuk:master.

inukshuk commented 8 years ago

No problem, please carry on :)

I noticed the merge_locale_with_style_locale there; it's great if you're working on that, I remember giving this a lot of thought at some point and was under the illusion that it was already implemented. If I'm not mistaken now, the idea was that the renderer merges all the candidate styles in order -- i.e., style-locale, de-AT, de-DE, en-US -- to create its immanent locale (good name!) which will be used for all processing and formatting. I'm pretty sure that at least merging of locales is already implemented, albeit not heavily tested.

In any case: awesome if you can get it done! I'd appreciate if you could make this a separate PR though, thanks!

walski commented 8 years ago

Hey, thanks for the feedback. We are currently working on a handful of fixes. Expect more (real ;)) PRs soon. I've found a solution for this particular problem, too that uses the merge feature of locales. That said, I'm not really sure if it is a good solution for an upstream PR. It's really tailored to our use-case. But I let you decide on that once it's ready :)