search

inukshuk / citeproc-ruby

A Citation Style Language (CSL) Cite Processor
101 stars 22 forks source link

"CiteProc requires the `unicode_utils` or `unicode` Gem on Ruby 2.3" #60

Open jrochkind opened 6 years ago

jrochkind commented 6 years ago

Updating citeproc-ruby from 1.1.8 to 1.1.10 (to get #54), also updates citeproc from 1.0.8 to 1.0.9.

When trying to launch my app, I now get the above message: "CiteProc requires the unicode_utils or unicode Gem on Ruby 2.3". I am pretty sure I did not get that before, and it's due to the update. Aha, yes. https://github.com/inukshuk/citeproc/commit/c14d3cd272698dd4aa52625dd140864b7a7bd6cb

  1. These gems are both pretty old, are they really needed on ruby 2.3, which has a lot of built in unicode? It looks like you determined upcase/downcase was not unicode aware on 2.3?

  2. Updating only a patch level (1.1.8 => 1.1.10, and 1.0.8 => 1.0.9) resulting in a change that makes your app no longer boot when before it would, is kind of sad. I would have rather had it continue using the old upcase/downcase if unicode utils are missing, but with a warning. And if the issue mentioned an example of the problem it was trying to fix, that'd be awesome too.

inukshuk commented 6 years ago

I was assuming everything would work on 2.3 without any Gems, but unfortunately that's not the case:

 >> RUBY_VERSION
 => "2.3.6"
 >> 'xúä'.upcase
 => "Xúä"
jrochkind commented 6 years ago

Aha, okay. It's done now, but personally I think it would have been better to use the unicode gems if installed, but if not installed continue doing old behavior, rather than raising and refusing to run -- ideally a patch release should not break your app.

elotroalex commented 6 years ago

I'm getting this with Jekyll Scholar 5.13.0 with Ruby 2.3.6. Was relieved to see that the issue is fresh. Happy to test on my machine new beta patches.

elotroalex commented 6 years ago

Just for the record: Once the 'unicode' gem is all bundled up, everything works again, of course.