inukshuk commented 2 years ago

I'm sorry, my thinking was that we'd add only the format validator functions here in order to keep all the EDTF-specific knowledge in this module. I'd prefer not to include the ajv and zschema helpers and dev-dependencies, because I feel they are out of scope here. Shall we just add the format validators or would you like to put everything into a edtf-formats package?

retorquere commented 2 years ago

Oh in that case I'll just spin it off to a separate module. With the new seasonIntervals option, the validation boils down to a call of parse.

codecov[bot] commented 2 years ago

Codecov Report

Merging #39 (473d967) into main (a7f2832) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   97.28%   97.32%   +0.04%     
==========================================
  Files          20       21       +1     
  Lines        2355     2396      +41     
==========================================
+ Hits         2291     2332      +41     
  Misses         64       64

Impacted Files	Coverage Δ
index.js	`100.00% <100.00%> (ø)`
src/json-schema.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7f2832...473d967. Read the comment docs.

retorquere commented 2 years ago

https://github.com/retorquere/json-schema-edtf

inukshuk commented 2 years ago

Good work!

inukshuk / edtf.js

JSON-schema formats for EDTF #39

Codecov Report