search

inukshuk / jekyll-scholar

jekyll extensions for the blogging scholar
MIT License
1.13k stars 101 forks source link

Filters are not applied before doing bibliography queries #226

Open IgnoredAmbience opened 6 years ago

IgnoredAmbience commented 6 years ago

Use case: I want query my bibliography based on author names that include UTF-8 diacritics, when the BibTeX file uses LaTeX-encoded diacritics.

I would expect that when querying the database that any filters specified (eg, the latex filter) in the configuration are applied. However this appears not to be the case -- filters seem to be only applied to the output.

Is this the intended behaviour? I'll happily fix this if it is not intended.

inukshuk commented 6 years ago

Good question. I think we originally applied the filters right after loading the bibliography but changed it for some reason? I'm not sure. At this point, I would say to just give it a try and if there are no failing tests it's fine.

IgnoredAmbience commented 6 years ago

I'll also skim the commit history to see if I can find why the change was made, so we don't repeat previous mistakes.

inukshuk commented 6 years ago

It may be related (or I'm mixing it up) with the issues about using raw to avoid double braces in bibtex being interpolated by liquid.