search

inukshuk / jekyll-scholar

jekyll extensions for the blogging scholar
MIT License
1.12k stars 102 forks source link

Support --locator for {% quote "source" %}Quote{% endquote %} #263

Closed alzeih closed 5 years ago

alzeih commented 5 years ago

When I use the cite tag with a locator, e.g:

{% cite "source" --locator 7 %}

It renders as, e.g:

(Author, 2019, p. 7)

However, when I use the quote tag with a locator, e.g:

{% quote "source" --locator 7 %}
Quote here.
{% endquote %}

It renders as, e.g: 

Quote here.

(Author, 2019)

Should the quote tag also accept a locator like the cite tag does?

I would like the page number to show up for the quotation too.

alzeih commented 5 years ago

It looks like adding 

optparse(arguments)

after https://github.com/inukshuk/jekyll-scholar/blob/master/lib/jekyll/scholar/tags/quote.rb#L13 is all that is needed to make this work.

This may have other consequences though I'm not aware of.

alzeih commented 5 years ago

I've created PR #264 to address this issue.