search

inukshuk / jekyll-scholar

jekyll extensions for the blogging scholar
MIT License
1.12k stars 102 forks source link

Allow detail page URLs to be customised by the user #271

Closed bronsonp closed 4 years ago

bronsonp commented 4 years ago

This pull request adds a new configuration setting "details_permalink" to allow for end users to customise the URLs of the details pages. For example, instead of URLs being hardcoded to be the citation key, the user may include the year, DOI, title, etc. This is similar to how normal Jekyll blog posts follow the URL pattern defined in the site's config file.

The default settings reproduce the existing behaviour of jekyll-scholar, so URLs will not change unless the user explicitly configures the new setting.

The pull request also includes a unit test for the new functionality.

inukshuk commented 4 years ago

Looks great, thanks! Will push this to RubyGems asap.