search

inukshuk / jekyll-scholar

jekyll extensions for the blogging scholar
MIT License
1.13k stars 101 forks source link

Fix dependency for Jekyll 4.0.0 #272

Open sgroth opened 5 years ago

sgroth commented 5 years ago

Currently, jekyll-scholar 5.16.0 depends on jekyll (~> 3.0). With jekyll 4.0.0 released, this dependency should be fixed (as long as there are no other compatibility issues).

sgroth commented 5 years ago

Changing s.add_runtime_dependency('jekyll', '~> 3.0') to s.add_runtime_dependency('jekyll', '~> 4.0') works flawlessly, but produces numerous and recurring Empty 'slug' generated for ''-warnings on build.

stevecheckoway commented 5 years ago

I've been using the fix in https://github.com/inukshuk/jekyll-scholar/pull/273 for quite a while without issues. But as mentioned there, that run time dependency might be too permissive.

inukshuk commented 5 years ago

@stevecheckoway I merged the PR, thanks!

We have two failing tests:

https://travis-ci.org/inukshuk/jekyll-scholar/jobs/575426363#L2179 https://travis-ci.org/inukshuk/jekyll-scholar/jobs/575426363#L2503

Both seem to be related to interpolation in details pages.