search

inukshuk / jekyll-scholar

jekyll extensions for the blogging scholar
MIT License
1.13k stars 101 forks source link

`details_link_for` not respecting `base` anymore #284

Closed ph03 closed 4 years ago

ph03 commented 4 years ago

With fe5a875 def details_link_for(entry, base = base_url) is not respecting the second base parameter anymore, resulting in wrong links if not empty

cc @bronsonp

bronsonp commented 4 years ago

@ph03 You are asking for the base parameter to be prepended to the URL for bibliography detail pages?

Would this fix this issue? https://github.com/bronsonp/jekyll-scholar/commit/97c7828ea88a0a07d16cd8f3d53b57d363ffacbd

ph03 commented 4 years ago

Yes, exactly, I think that should fix it - note that before fe5a875 the base was prepended in a similar way:

image

bronsonp commented 4 years ago

OK, I will put in a pull request.

inukshuk commented 4 years ago

Thanks! The fix landed in 6.3.3.

ph03 commented 4 years ago

awesome, thanks guys!