Want to add some integration test. Some idea where to put them?

inukshuk / wapiti-ruby

Wicked fast Conditional Random Fields for Ruby

Other

37 stars 7 forks source link

Want to add some integration test. Some idea where to put them? #7

Open clbustos opened 5 years ago

clbustos commented 5 years ago

I want to put some integration test to check that all estimation methods and options could be used under common setting. Could be better to add it under /spec/integration or inside /spec/wapiti dir?

Thanks

inukshuk commented 5 years ago

Hmm, I'm not sure myself; I'd probably start out putting them into spec/wapiti (in the model, native, or options file, depending on what I'm testing) unless those tests need a very different setup. If you don't mind, just start with what feels right to you and I'll review the PR when you're ready.

If you're working in the native module, you may want to keep an eye open for #5

Happy hacking!