search

inukshuk / wapiti-ruby

Wicked fast Conditional Random Fields for Ruby
Other
37 stars 7 forks source link

Remove taint checking (ruby 3.2.0 compat) #9

Closed bbonamin closed 1 year ago

bbonamin commented 1 year ago

This change removes taint checking, which has been deprecated since Ruby 2.7 and has no effect.

Ruby 3.2.0 completely removes taint support, so this gem currently fails to compile under that Ruby version.

I don't think this should have any negative consequences for older Ruby versions.

See this thread for more info and links to similar gems with c extensions having taint checking removed: https://bugs.ruby-lang.org/issues/16131#note-24

inukshuk commented 1 year ago

Thanks!