fix: visibility of reqs::Order constructors

inv2004 / coinbase-pro-rs

Coinbase pro client for Rust

Apache License 2.0

145 stars 56 forks source link

fix: visibility of reqs::Order constructors #10

Closed rschmukler closed 5 years ago

rschmukler commented 5 years ago

Please forgive me if this isn't actually necessary. I believe that pub(crate) is ambiguous on struct constructors and doesn't actually cause these functions to be exposed publicly.

If I'm incorrect here, please excuse this PR and let me know the correct syntax to create a request using market or limit constructors from an external package.

inv2004 commented 5 years ago

Merged, it was wrong decision to think that it not necessary to oneone. Will pub 0.4.1 now.

inv2004 commented 5 years ago

Thank you for your help with the library.

rschmukler commented 5 years ago

Thank you for the quick publishing!