search

inv2004 / coinbase-pro-rs

Coinbase pro client for Rust
Apache License 2.0
145 stars 56 forks source link

Async updates #15

Closed yovanoc closed 3 years ago

yovanoc commented 4 years ago

Hello!

Have you planned to update this project with new async std and/or tokio updates?

Thanks!

inv2004 commented 4 years ago

Hello, I was trying long time ago and found that generators does not work good and very unstable. I do not remember # of the issue I commented about it in rust.

Probably I will try one more time a bit later.

Thank you for reminding me.

Regards,

On Sat, Jan 18, 2020, 17:45 Christopher Yovanovitch < notifications@github.com> wrote:

Hello!

Have you planned to update this project with new async std and/or tokio updates?

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/inv2004/coinbase-pro-rs/issues/15?email_source=notifications&email_token=ABFYITPCTJXETLJ6C3MHA3TQ6MIYPA5CNFSM4KITL6F2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IHDO55Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFYITK2MTXF244IVGTBIQ3Q6MIYPANCNFSM4KITL6FQ .

yovanoc commented 4 years ago

No worries, I just made a little trading bot for fun so nothing to worry about x)

Was just a little question. So thank you for your work and I start to watch the project :)

favilo commented 3 years ago

I just sent a PR to address this, since I was interested in it, too. #16

inv2004 commented 3 years ago

@favilo Thank you, I will publish it like major version update after tests passed

inv2004 commented 3 years ago

@favilo Unfortunately I do not want to push version until tests is complete, but I do not have time to complete it now.

Please point cargo to git

favilo commented 3 years ago

No problem. I am actually writing a lot of code to update this crate to a more standardized 2018 edition of the code.

Moving tests into the individual src files. Removing #[macro_use] and the extern crate lines. Using thiserror instead of failure. Marking enums as #[non_exhaustive] so we don't have to update the major version every time we add an option to it.

I'm also going to be adding some of the missing API. In particular, get_account_history currently doesn't work, because we are missing a Conversion type.

I was planning on just dropping a large PR, but I don't mind breaking it apart if you'd prefer.

inv2004 commented 3 years ago

@favilo Thank you for the huge PR you have made! And especially about tokio 0.3 part.

0.6.2 pushed