search

inv2004 / coinbase-pro-rs

Coinbase pro client for Rust
Apache License 2.0
145 stars 56 forks source link

fixing build and updating all dependencies to most recent versions #18

Closed sebest closed 3 years ago

sebest commented 3 years ago

When I tried to use coinbase-pro-rs it was not compiling: I had many errors related to serde.

I fixed the errors by adding:

features = ["derive"]

I noticed that many dependencies are outdated, so I updated to the most recent versions and fixed the code when the API were slightly different.

Also some of the tests are flaky: "check_latency" and "check_full", I increased the timeouts.

inv2004 commented 3 years ago

Thank you for the PR. Let me check, because I run tests during tokio 0.3 update Nov 2020 - not so old. Everything was ok

sebest commented 3 years ago

I think that the failed test on the second diff are caused by flaky test, it looks like it depends on the coinbase sandbox which seems to be a bit unpredictable.

sebest commented 3 years ago

The first diff does not fix tokio build but serde.

sebest commented 3 years ago

Hi, any update on this PR? thank you

inv2004 commented 3 years ago

@sebest Merged. Sorry for delay. will lift cargo version soon