Open GoogleCodeExporter opened 9 years ago
Add a ">" to the end of src="foobaz.html"
Original comment by robl...@chromium.org
on 13 Jun 2013 at 7:52
There is a bug in the regex!
The .*?> is still not enough to capture the end tag. You may need to check for
both /> and </include>
Original comment by robl...@chromium.org
on 28 Jun 2013 at 1:27
Hi robliao@, do you want to upload a code review to codereview.chromium.org
that fixes this? I will be happy to review it and land it for you. You just
run [ gcl upload ] or [ git cl upload ] in your checkout of grit-i18n to upload
the code review.
Original comment by joi@chromium.org
on 28 Jun 2013 at 10:31
I can do that. You'll get the CR mail. I'll send the change around early next
week.
Original comment by robl...@google.com
on 28 Jun 2013 at 4:45
Original issue reported on code.google.com by
robl...@chromium.org
on 13 Jun 2013 at 7:51