search

invandy / Oregon_NR

Arduino library for Oregon Scientific and Explore Scientific wireless sensors decode and simulate
Other
31 stars 21 forks source link

Please translate inline comments #5

Open Saphareas opened 4 years ago

Saphareas commented 4 years ago

Hi, first of all thank you! I've been looking for such a library for over a year. Could you please translate the inline comments to English? I would like to add support for the PCR800 rain sensor (0x2914), but first I need to be able to understand your code.

invandy commented 4 years ago

Hello! Thank you for you interest and sorry for long delay in reply. I plan to translate all comments to English but with my English skill it may require a lot of time :). However if PRC800 packet length, CRC and checksum is the same like other v3 sensors, there is no need to understainding all my code. You just need to add handler of this sensor in check_CRC() and capture() functions. By the way I also have in my "todos" the adding support of PRC800. If you need any explanation of code - let me know what part of comments is to be transleted in the first place Regards. Sergey.

Saphareas commented 4 years ago

Ok, could you at least recommit Oregon_NR.cpp with correct encoding? Because the cyrillic characters are f*ed up.

By the way: Merry Christmas