Ok, so after doing more research, I think the issue is that the slack job defines needs: test which says "Only run this once 'test' is done", and it also defines if: github.event_name == 'schedule' which says "Only run this when the CI is triggered by the schedule".
Ok, so after doing more research, I think the issue is that the slack job defines
needs: test
which says "Only run this once 'test' is done", and it also definesif: github.event_name == 'schedule'
which says "Only run this when the CI is triggered by the schedule".The problem is that if
test
fails then theneeds
criteria fails and the job is skipped. If you set theif
toif: always()
it will run aftertest
regardless iftest
passed or failed. So if we add that to the if criteria, we should get the slack job to run only on the schedule regardless if the tests passed or not. (https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#example-not-requiring-dependent-jobs-to-be-successful)p.s. sorry for so many PR's @rofinn