search

invenia / Impute.jl

Imputation methods for missing data in julia
https://invenia.github.io/Impute.jl/latest/
Other
76 stars 11 forks source link

Fixes compatibility for tests running against Juliav1.8 #131

Closed BaileyBox closed 1 year ago

BaileyBox commented 1 year ago

When running Impute.jl tests against Julia1.8, we run into a problem when calling the nrmsd() function here (from Distances.jl, function found here).

There error we get is as follows:

Screen Shot 2022-10-03 at 4 01 26 PM

Since there were some changes/refactoring to the extrema() function, it created a MethodError, where it couldn't match the adjoint() method with what we passed in (adjoint(data) from within the failing test).

Flipping the two around fixes the tests, but not the root of the problem. I'm not sure if this is the correct solution, or if I have to report this as an issue with JuliaLang itself. I know a bunch of other stuff changed around mapping, so maybe this isn't a problem here, but a new limitation with the language itself.

Happy to hear some feedback about this :)

BaileyBox commented 1 year ago

@rofinn is it correct to swap these 2 around to fix this? Or should I try to find another solution (Reporting bug to JuliaLang)?

BaileyBox commented 1 year ago

I'm unsure why the x64 julia check failed, when the exact same test passed previously.