search

invenia / Impute.jl

Imputation methods for missing data in julia
https://invenia.github.io/Impute.jl/latest/
Other
76 stars 11 forks source link

CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #136

Closed github-actions[bot] closed 10 months ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the StatsBase package from 0.32, 0.33 to 0.32, 0.33, 0.34. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

svilupp commented 10 months ago

Hi everyone,

Would it be possible to bump up the compat? Impute.jl is a dependency of DataFrames.jl, so it's holding back a lot of projects from upgrading to StatsBase 0.34.

I wanted to check the CI failures, but the logs have expired. Would it be possible to re-run it?

rofinn commented 10 months ago

Can you point me to where DataFrames is depending on Impute cause it shouldn't? Looking at the Project.toml, DataFrames doesn't depend on Impute, and Impute only uses DataFrames as a test dependency.

rofinn commented 10 months ago

Regardless, bumping this should be fine for now. The test are failing on Julia 1.9 and higher because we don't have the latest AxisKeys release.

svilupp commented 10 months ago

Aaah, my bad! I misread the output of the dependency graph... You're right that it's not a dep for DataFrames! It was coming from a different package and when I locally bumped it up, it all started working, so I haven't investigated further.

Thank you for responding so quickly!

rofinn commented 10 months ago

Looks like there is a minor issue with bumping StatsBase in that it identified a numeric instability with our KNN tests. Shouldn't block a release, but will need to be fixed.