search

invenia / Impute.jl

Imputation methods for missing data in julia
https://invenia.github.io/Impute.jl/latest/
Other
76 stars 11 forks source link

Bump Distances #64

Closed AlexRobson closed 3 years ago

AlexRobson commented 3 years ago

Bumps distances to 0.9.

Needed for an internal package to work with KernelFunctions (which requires Distances 0.9)

EDIT: Issues are due to the SRS tests - investigating incororating the solution in #63

rofinn commented 3 years ago

I'll just make a separate PR for the SRS test fix as I intentionally left it as a separate commit. Didn't think anyone would need it that quickly :) FWIW, you can always cherry-pick that commit into your branch rather than re-writing it.

rofinn commented 3 years ago

Alright, if you wanna approve and merge the new MR and rebase then I can merge and tag this when I start tomorrow morning.

AlexRobson commented 3 years ago

Thanks - yeah this makes sense as a separate MR :)

Approvied, but looks like I don't personally have permissions to make the merge though for #65

rofinn commented 3 years ago

Do you mind if I rebase your branch so we can merge and tag this?

AlexRobson commented 3 years ago

Rebased onto master, hopefully this passes everything with #65 in now - ty