invenia / Impute.jl

Imputation methods for missing data in julia
https://invenia.github.io/Impute.jl/latest/
Other
76 stars 11 forks source link

DeclareMissings is not a real Imputor #87

Closed rofinn closed 3 years ago

rofinn commented 3 years ago
  1. It often won't return the input data type if the input data doesn't allowmissings.
  2. The API is sufficiently different in that it doesn't really apply across dimensions like the other imputors.
  3. It's actively making more missings rather than estimating realistic values which puts it closer to the Filter method than a a real imputor.

Closes #77

rofinn commented 3 years ago

If there aren't any objections to this I'll probably just merge it in a day or so.