search

invenia / Intervals.jl

Non-iterable ranges
MIT License
35 stars 18 forks source link

Set minimum supported julia version to 1.6 (LTS) #186

Closed pabloferz closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #186 (aa3933c) into master (2fe33fd) will increase coverage by 0.57%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   81.15%   81.73%   +0.57%     
==========================================
  Files          11       11              
  Lines         605      624      +19     
==========================================
+ Hits          491      510      +19     
  Misses        114      114
Impacted Files Coverage Δ
src/Intervals.jl 100.00% <ø> (ø)
src/compat.jl 100.00% <ø> (ø)
src/interval.jl 96.36% <100.00%> (+0.10%) :arrow_up:
src/description.jl 100.00% <0.00%> (ø)
src/inclusivity.jl 100.00% <0.00%> (ø)
src/anchoredinterval.jl 99.12% <0.00%> (+0.01%) :arrow_up:
src/endpoint.jl 98.11% <0.00%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fe33fd...aa3933c. Read the comment docs.

omus commented 2 years ago

🎉 Very nice work! I suggest we should also increase the minimum version of Julia in the Project.toml to be 1.6 as we no longer support earlier versions and don't want people accidentally installing this on older Julia revisions. Besides that I'm happy to approve.

Hopefully, someone from Invenia can validate the unresolved discussion.

omus commented 2 years ago

I'll merge this by EOD unless there are objections. If Invenia wants to keep testing against Julia 1.5 we can always add that back in (hopefully not though)