search

invenia / Intervals.jl

Non-iterable ranges
MIT License
35 stars 18 forks source link

Handle empty-interval edge case in `find_intersections` #201

Open haberdashPI opened 2 years ago

haberdashPI commented 2 years ago

Closes #200

Title says it all. This fix also will address some edge cases where find_intersections would throw a StackOverflowError when passed an incorrect type.

Small aside: When I ran tests locally there was a failure on 1.8 (had to run on 1.7). Looks to be related to a now closed issue in 1.8.

codecov[bot] commented 2 years ago

Codecov Report

Merging #201 (8eec69f) into master (2999a5d) will increase coverage by 0.03%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   84.31%   84.35%   +0.03%     
==========================================
  Files          12       12              
  Lines         848      850       +2     
==========================================
+ Hits          715      717       +2     
  Misses        133      133
Impacted Files Coverage Δ
src/interval_sets.jl 92.21% <75.00%> (+0.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.