search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Drop support for Julia 0.6 #109

Closed ararslan closed 5 years ago

ararslan commented 5 years ago

There are two commits here:

  1. Drop support for 0.6 with all of the changes that entails, and
  2. Replace the dependency on Nullables by using Unions with Nothing, wrapping with Some where appropriate.
codecov[bot] commented 5 years ago

Codecov Report

Merging #109 into master will decrease coverage by 3.7%. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #109      +/-   ##
=========================================
- Coverage    98.3%   94.6%   -3.71%     
=========================================
  Files          11      11              
  Lines         295     278      -17     
=========================================
- Hits          290     263      -27     
- Misses          5      15      +10
Impacted Files Coverage Δ
src/Memento.jl 100% <ø> (ø) :arrow_up:
src/memento_test.jl 100% <ø> (ø) :arrow_up:
src/formatters.jl 90% <100%> (-10%) :arrow_down:
src/handlers.jl 95.12% <100%> (-4.88%) :arrow_down:
src/stdlib.jl 37.5% <37.5%> (-12.5%) :arrow_down:
src/records.jl 90% <91.66%> (-10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 860eed7...1ed4c19. Read the comment docs.

ararslan commented 5 years ago

Yeah tbh I don't understand the coverage changes.

ararslan commented 5 years ago

If this is good to go, does someone want to push the button? I don't have permission to do so.