search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Change sentinel for test_warn error message #117

Closed nicoleepp closed 5 years ago

nicoleepp commented 5 years ago

Closes #106

The error message printed would be:

julia> @test_warn(TESTLOG, "ModA warning 1", ModA.danger())
Test Failed at /Users/nicoleepp/.julia/dev/Memento/src/memento_test.jl:34
  Expression: handler.found[1] == $(Expr(:escape, "warn"))
   Evaluated: nothing == "warn"
ERROR: There was an error during testing

Which to me is clearer than "" since the pattern matching didn't find anything. Open to better sentinel suggestions though.

codecov[bot] commented 5 years ago

Codecov Report

Merging #117 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #117   +/-   ##
======================================
  Coverage    95.9%   95.9%           
======================================
  Files          12      12           
  Lines         293     293           
======================================
  Hits          281     281           
  Misses         12      12
Impacted Files Coverage Δ
src/memento_test.jl 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31b3164...4c5821f. Read the comment docs.