search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Remove IO as a parameter to Handler #121

Closed nicoleepp closed 4 years ago

nicoleepp commented 5 years ago

Closes #89

Open for discussion

nicoleepp commented 5 years ago

This is a breaking change

codecov[bot] commented 5 years ago

Codecov Report

Merging #121 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          12       12           
  Lines         307      307           
=======================================
  Hits          295      295           
  Misses         12       12
Impacted Files Coverage Δ
src/handlers.jl 95.12% <ø> (ø) :arrow_up:
src/memento_test.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21eca06...14f09d8. Read the comment docs.

rofinn commented 5 years ago

This seems fine. I think we might want an abstract IOHandler type at some point, but this is fine for now.