search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Fix redefinition of getindex #124

Closed iamed2 closed 5 years ago

iamed2 commented 5 years ago

A quick attempt at fixing #123

iamed2 commented 5 years ago

Well that doesn't work

nicoleepp commented 5 years ago

We might need to use depwarn instead of @deprecate

iamed2 commented 5 years ago

I think we can just import getindex

codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   95.75%   95.73%   -0.02%     
==========================================
  Files          12       12              
  Lines         306      305       -1     
==========================================
- Hits          293      292       -1     
  Misses         13       13
Impacted Files Coverage Δ
src/Memento.jl 100% <ø> (ø) :arrow_up:
src/memento_test.jl 100% <100%> (ø) :arrow_up:
src/formatters.jl 94% <100%> (ø) :arrow_up:
src/records.jl 92.85% <100%> (-0.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c145755...b1f6679. Read the comment docs.

rofinn commented 5 years ago

Should we update all the cases where we're calling the deprecated getindex except for 1?