search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Allow `Expection` in do-block syntax #127

Closed nickrobinson251 closed 4 years ago

nickrobinson251 commented 5 years ago

Do-block sytax can be used for Strings

julia> error(getlogger()) do
           "Woops!"
       end
[error | root]: Woops!
ERROR: Woops!
Stacktrace:
 [1] error(::getfield(Main, Symbol("##21#22")), ::Logger) at /Users/nick/.julia/packages/Memento/UgJr2/src/loggers.jl:434
 [2] top-level scope at none:0

But does not work for Excpetions

julia> error(getlogger()) do
           DomainError("Woops!")
       end
ERROR: MethodError: Cannot `convert` an object of type DomainError to an object of type AbstractString

Would it be possible for this to be added?

rofinn commented 4 years ago

Yeah, that should be pretty easy to change.