search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Updated documentation, esp. conclusion.md, and fixed add_handler, STDOUT, current_module() #137

Open phyatt-corp opened 4 years ago

phyatt-corp commented 4 years ago

Mostly documentation fixes.

Conclusion.md is much more functional than it was before.

In my application logs are often sent or written right as julia exits, and the @async logs wouldn't work in that case, so I added an atexit() hook for cleaning up the REST log tasks in the conclusion.md example to handle this case.

codecov[bot] commented 4 years ago

Codecov Report

Merging #137 into master will decrease coverage by 0.1%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   96.06%   95.95%   -0.11%     
==========================================
  Files          12       12              
  Lines         305      297       -8     
==========================================
- Hits          293      285       -8     
  Misses         12       12
Impacted Files Coverage Δ
src/Memento.jl 100% <ø> (ø) :arrow_up:
src/records.jl 92.85% <ø> (ø) :arrow_up:
src/memento_test.jl 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04ac56c...2d28e2b. Read the comment docs.

rofinn commented 4 years ago

Alright, the non-example commits seem pretty simple, so I'm going to cherry-pick them into a separate PR that we can merge quickly.